refactor(@angular/build): use new encapsulate style helper for HMR #28492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@angular/compiler` package now has an updated `encapsulateStyle` helper that allows directly providing the component identifier as an argument. This avoids needing to perform an additional regular expression replace with the internal marker text. Also, the component identifier validity check has been updated to support unicode characters in the event they happen to be used for the application identifier.
clydin
added
the
action: review
alan-agius4
approved these changes
Sep 26, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@angular/compilerpackage now has an updatedencapsulateStylehelperthat allows directly providing the component identifier as an argument.
This avoids needing to perform an additional regular expression replace
with the internal marker text.