Skip to content

Conversation

niklas-wortmann
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The editorConfig generated by ng new specified quote_type = single for ts files. This is not a valid configuration option within editorConfig, instead editor could use it, but AFAIK no one utilizes this (editorconfig/editorconfig-vscode#95). JetBrains IDEs have the option with the ij_ prefix to set custom settings, and ij_use_double_quote=false will lead to autogenerated code (e.g. autoimports) to use single quotes

Issue Number: N/A

What is the new behavior?

JetBrains IDEs will use single quotes by default

Does this PR introduce a breaking change?

  • Yes
  • No

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Sep 25, 2024
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you fix the commit message type and scope to the below please?

fix(@schematics/angular):

Thanks.

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release and removed detected: feature PR contains a feature commit labels Sep 26, 2024
@niklas-wortmann
Copy link
Contributor Author

done, thanks!

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 26, 2024
@clydin clydin merged commit 4179bf2 into angular:main Sep 26, 2024
32 checks passed
@clydin
Copy link
Member

clydin commented Sep 26, 2024

The changes were merged into the following branches: main, 18.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants