fix(@angular/ssr): improve handling of route mismatches between Angular server routes and Angular router #28500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
error-unknown-route
branch
2 times, most recently
from
1521377 to
7fd2fdc
Compare
…ar server routes and Angular router This commit resolves an issue where routes defined in the Angular server routing configuration did not match those in the Angular router. Previously, discrepancies between these routes went unnoticed by users. With this update, appropriate error messages are now displayed when mismatches occur, enhancing the developer experience and facilitating easier troubleshooting.
alan-agius4
force-pushed
the
error-unknown-route
branch
from
7fd2fdc to
c963dad
Compare
alan-agius4
force-pushed
the
error-unknown-route
branch
from
15aa9df to
731adc9
Compare
AndrewKushnir
approved these changes
Sep 26, 2024
| route: currentRoutePath, | ||
| }; | ||
|
|
||
| delete metadata.matched; |
There was a problem hiding this comment.
The delete operation used to cause deopt in VM, may be use null or undefined instead?
Suggested change
| delete metadata.matched; | |
| metadata.matched = null; |
There was a problem hiding this comment.
This is done during build time so I am less worried about that, if we set undefined or null, we’d need to filter it out so not to include it in the manifest
alan-agius4
force-pushed
the
error-unknown-route
branch
from
731adc9 to
135dcfa
Compare
alan-agius4
added
action: merge
…erMode.AppShell` This change introduces error handling to ensure that when multiple routes are configured with `RenderMode.AppShell`, an error message is displayed. This prevents misconfiguration and enhances clarity in route management.
alan-agius4
force-pushed
the
error-unknown-route
branch
from
135dcfa to
3486248
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(@angular/ssr): show error when multiple routes are set with
RenderMode.AppShell**This change introduces error handling to ensure that when multiple routes are configured with
RenderMode.AppShell, an error message is displayed. This prevents misconfiguration and enhances clarity in route management.fix(@angular/ssr): improve handling of route mismatches between Angular server routes and Angular router
This commit resolves an issue where routes defined in the Angular server routing configuration did not match those in the Angular router. Previously, discrepancies between these routes went unnoticed by users. With this update, appropriate error messages are now displayed when mismatches occur, enhancing the developer experience and facilitating easier troubleshooting.