perf(@angular/ssr): cache generated inline CSS for HTML #28503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
cache-inline-css
branch
from
8b5a16e to
e437da8
Compare
alan-agius4
force-pushed
the
cache-inline-css
branch
3 times, most recently
from
88632fc to
a73a101
Compare
alan-agius4
force-pushed
the
cache-inline-css
branch
from
a73a101 to
c6dd469
Compare
alan-agius4
force-pushed
the
cache-inline-css
branch
7 times, most recently
from
af25675 to
f9d0e38
Compare
AndrewKushnir
approved these changes
Sep 28, 2024
Implement LRU cache for inlined CSS in server-side rendered HTML. This optimization significantly improves server-side rendering performance by reusing previously inlined styles and reducing the overhead of repeated CSS inlining. Performance improvements observed: Performance improvements observed: * **Latency:** Reduced by ~18.1% (from 1.01s to 827.47ms) * **Requests per Second:** Increased by ~24.1% (from 381.16 to 472.85) * **Transfer per Second:** Increased by ~24.1% (from 0.87MB to 1.08MB) These gains demonstrate the effectiveness of caching inlined CSS for frequently accessed pages, resulting in a faster and more efficient user experience.
alan-agius4
force-pushed
the
cache-inline-css
branch
from
f9d0e38 to
c86504e
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement LRU cache for inlined CSS in server-side rendered HTML.
This optimization significantly improves server-side rendering performance by reusing previously inlined styles and reducing the overhead of repeated CSS inlining.
Performance improvements observed:
These gains demonstrate the effectiveness of caching inlined CSS for frequently accessed pages, resulting in a faster and more efficient user experience.
Edit: Previously the numbers were calculated not using the Average but the Max.