feat(@angular-devkit/build-angular): karma+esbuild+watch #28519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
jkrems
added
action: review
|
I think this was the last blocker in terms of "passes all tests". I'll likely try it out once these PRs are part of the next version to see if there's anything else "obviously" wrong with it. |
jkrems
force-pushed
the
jk-karma-watch
branch
from
f24c4a6 to
287119f
Compare
clydin
reviewed
Sep 30, 2024
packages/angular_devkit/build_angular/src/builders/karma/application_builder.ts
Show resolved
Hide resolved
jkrems
force-pushed
the
jk-karma-watch
branch
from
287119f to
6bf444c
Compare
This introduces support for `--watch` when using the application builder. It's tested as far as the relevant test case is concerned. But I wouldn't be surprised if there's still some rough corners.
jkrems
force-pushed
the
jk-karma-watch
branch
from
6bf444c to
427d20d
Compare
clydin
approved these changes
Sep 30, 2024
jkrems
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for
--watchwhen using the application builder. It's tested as far as the relevant test case is concerned. But I wouldn't be surprised if there's still some rough corners.NOTE: Currently includes the commit from #28518 because the two touch some of the same code.Rebased.