fix(@angular/build): separate Vite cache by project #28540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Vite prebundled dependencies were stored in a shared directory across all projects, which caused the `_metadata.json` files to be overwritten. This resulted in undefined behavior, such as re-optimizing dependencies on each run when multiple projects were present in the workspace. Additionally, it introduced conflicts when running multiple `ng serve` processes simultaneously. Closes angular#28536
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
clydin
approved these changes
Oct 1, 2024
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 18.2.x |
|
@alan-agius4 Is it possible to backport to 17? |
|
@marob, no as this is not a security fix or a newly introduced bug. See: https://angular.dev/reference/releases#lts-fixes |
marob
added a commit
to ProgrammeVitam/vitam-ui
that referenced
this pull request
Oct 3, 2024
As we can't upgrade to Angular 18 for now, here is a backport of angular/angular-cli#28540 to fix "504 Outdated Optimize Dep"
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Vite prebundled dependencies were stored in a shared directory across all projects, which caused the
_metadata.jsonfiles to be overwritten. This resulted in undefined behavior, such as re-optimizing dependencies on each run when multiple projects were present in the workspace. Additionally, it introduced conflicts when running multipleng serveprocesses simultaneously.Closes #28536