Skip to content

Avoid for await...of with promise arrays #28557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Avoid for await...of with promise arrays #28557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f294ca3
refactor(@angular-devkit/build-angular): avoid for await...of with pr…
clydin Oct 2, 2024
c7d78b9
refactor(@angular-devkit/schematics): avoid for await...of with promi…
clydin Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/src/utils/tailwind.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export async function findTailwindConfigurationFile(
);

// A configuration file can exist in the project or workspace root
for await (const { root, files } of dirEntries) {
for (const { root, files } of await Promise.all(dirEntries)) {
for (const potentialConfig of tailwindConfigFiles) {
if (files.has(potentialConfig)) {
return join(root, potentialConfig);
Expand Down
10 changes: 8 additions & 2 deletions packages/angular_devkit/schematics/src/rules/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,14 @@ export function empty(): Source {
export function chain(rules: Iterable<Rule> | AsyncIterable<Rule>): Rule {
return async (initialTree, context) => {
let intermediateTree: Observable<Tree> | undefined;
for await (const rule of rules) {
intermediateTree = callRule(rule, intermediateTree ?? initialTree, context);
if (Symbol.asyncIterator in rules) {
for await (const rule of rules) {
intermediateTree = callRule(rule, intermediateTree ?? initialTree, context);
}
} else {
for (const rule of rules) {
intermediateTree = callRule(rule, intermediateTree ?? initialTree, context);
}
}

return () => intermediateTree;
Expand Down