Skip to content

refactor(@angular/ssr): Convert crypto unavailable error to a soft error #28561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

refactor(@angular/ssr): Convert crypto unavailable error to a soft error #28561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/angular/ssr/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,17 @@ export class AngularServerApp {
return this.assets.getServerAsset(fileName);
});

if (isSsrMode) {
// TODO(alanagius): remove once Node.js version 18 is no longer supported.
if (isSsrMode && typeof crypto === 'undefined') {
// eslint-disable-next-line no-console
console.error(
`The global 'crypto' module is unavailable. ` +
`If you are running on Node.js, please ensure you are using version 20 or later, ` +
`which includes built-in support for the Web Crypto module.`,
);
}

if (isSsrMode && typeof crypto !== 'undefined') {
// Only cache if we are running in SSR Mode.
const cacheKey = await sha256(html);
let htmlWithCriticalCss = this.criticalCssLRUCache.get(cacheKey);
Expand Down
9 changes: 0 additions & 9 deletions packages/angular/ssr/src/utils/crypto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,6 @@
* represented as a hexadecimal string.
*/
export async function sha256(data: string): Promise<string> {
if (typeof crypto === 'undefined') {
// TODO(alanagius): remove once Node.js version 18 is no longer supported.
throw new Error(
`The global 'crypto' module is unavailable. ` +
`If you are running on Node.js, please ensure you are using version 20 or later, ` +
`which includes built-in support for the Web Crypto module.`,
);
}

const encodedData = new TextEncoder().encode(data);
const hashBuffer = await crypto.subtle.digest('SHA-256', encodedData);
const hashParts: string[] = [];
Expand Down