Skip to content

refactor: remove unused methods and locals #28562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

refactor: remove unused methods and locals #28562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/cli/src/command-builder/schematics-command-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export abstract class SchematicsCommandModule
}

private getProjectName(): string | undefined {
const { workspace, logger } = this.context;
const { workspace } = this.context;
if (!workspace) {
return undefined;
}
Expand Down
10 changes: 0 additions & 10 deletions packages/angular_devkit/build_angular/src/utils/process-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,16 +365,6 @@ function unwrapTemplateLiteral(
return [messageParts, expressions];
}

function unwrapLocalizeCall(
path: NodePath<types.CallExpression>,
utils: LocalizeUtilityModule,
): [TemplateStringsArray, types.Expression[]] {
const [messageParts] = utils.unwrapMessagePartsFromLocalizeCall(path);
const [expressions] = utils.unwrapSubstitutionsFromLocalizeCall(path);

return [messageParts, expressions];
}

async function loadLocaleData(path: string, optimize: boolean): Promise<string> {
// The path is validated during option processing before the build starts
const content = await fs.readFile(path, 'utf8');
Expand Down
8 changes: 6 additions & 2 deletions packages/ngtools/webpack/src/ivy/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export class AngularWebpackPlugin {
}

apply(compiler: Compiler): void {
const { NormalModuleReplacementPlugin, WebpackError, util } = compiler.webpack;
const { NormalModuleReplacementPlugin, util } = compiler.webpack;
this.webpackCreateHash = util.createHash;

// Setup file replacements with webpack
Expand Down Expand Up @@ -648,7 +648,11 @@ export class AngularWebpackPlugin {
];
diagnosticsReporter(diagnostics);

const transformers = createJitTransformers(builder, this.compilerCli, this.pluginOptions);
const transformers = createJitTransformers(
builder,
this.compilerCliTooling,
this.pluginOptions,
);

return {
fileEmitter: this.createFileEmitter(builder, transformers, () => []),
Expand Down
3 changes: 1 addition & 2 deletions packages/ngtools/webpack/src/transformers/find_image_domains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@
* found in the LICENSE file at https://angular.dev/license
*/

import * as ts from 'typescript';
import ts from 'typescript';

const TARGET_TEXT = '@NgModule';
const BUILTIN_LOADERS = new Set([
'provideCloudflareLoader',
'provideCloudinaryLoader',
Expand Down