feat(@angular/build): introduce ssr.experimentalPlatform option
#28598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
changed the title
experimentalNodeless option for SSR buildsexperimentalNodeless option for SSR builds
angular-robot
bot
added
detected: feature
alan-agius4
changed the title
experimentalNodeless option for SSR buildsssr.experimentalPlatform option
alan-agius4
force-pushed
the
nodeless
branch
2 times, most recently
from
98f3392 to
bf03e80
Compare
alan-agius4
added
target: major
alan-agius4
force-pushed
the
nodeless
branch
3 times, most recently
from
f746b82 to
4f8723a
Compare
alan-agius4
added
the
action: review
|
Note: The test failure occurs due to the current test structure relying on #28571. Once that PR is merged, the test will pass successfully. |
dgp1130
approved these changes
Oct 9, 2024
| const port = await findFreePort(); | ||
| await execAndWaitForOutputToMatch( | ||
| 'npx', | ||
| ['-y', 'listhen', './dist/test-project/server/server.mjs', `--port=${port}`], |
There was a problem hiding this comment.
Question: Should listhen be in our devDependencies? That way our bazel test doesn't need network access to download it dynamically and pin the dependency insulate us from breaking changes.
There was a problem hiding this comment.
Since it’s used only in a single test I preferred to use npx. I can add a version specifier though.
This commit introduces a new option called `experimentalPlatform` to the Angular SSR configuration. The `experimentalPlatform` option allows developers to specify the target platform for the server bundle, enabling the generation of platform-neutral bundles suitable for deployment in environments like edge workers and other serverless platforms that do not rely on Node.js APIs. This change enhances the portability of Angular SSR applications and expands their deployment possibilities. **Note:** that this feature does not include polyfills for Node.js modules and is experimental, subject to future changes.
clydin
approved these changes
Oct 9, 2024
alan-agius4
added
action: merge
1 task
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new option called
experimentalPlatformto the Angular SSR configuration.The
experimentalPlatformoption allows developers to specify the target platform for the server bundle, enabling the generation of platform-neutral bundles suitable for deployment in environments like edge workers and other serverless platforms that do not rely on Node.js APIs.This change enhances the portability of Angular SSR applications and expands their deployment possibilities.
Note: that this feature does not include polyfills for Node.js modules and is experimental, subject to future changes.