fix(@angular/build): synchronize import/export conditions between bundler and TypeScript #28633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
action: review
clydin
force-pushed
the
application/sync-conditions
branch
from
3b198f2 to
2700b17
Compare
…dler and TypeScript To improve type-checking and reduce hard to diagnose errors when using the new `production`/`development` conditions, the set of conditions used by the bundler are now also synchronized with those used by TypeScript. This helps ensure that type mismatches are avoided by type-checking against the actual file that will be bundled into the output.
clydin
force-pushed
the
application/sync-conditions
branch
from
2700b17 to
98a89af
Compare
jkrems
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve type-checking and reduce hard to diagnose errors when using the new
production/developmentconditions, the set of conditions used by the bundler are now also synchronized with those used by TypeScript. This helps ensure that type mismatches are avoided by type-checking against the actual file that will be bundled into the output.