Skip to content

refactor(@angular/build): use ETags for dev-server resource requests #28732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

refactor(@angular/build): use ETags for dev-server resource requests #28732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,21 @@ export function createAngularAssetsMiddleware(
}
}

// Avoid resending the content if it has not changed since last request
const etag = `W/"${outputFile.contents.byteLength}-${outputFile.hash}"`;
if (req.headers['if-none-match'] === etag) {
res.statusCode = 304;
res.end();

return;
}

const mimeType = lookupMimeType(extension);
if (mimeType) {
res.setHeader('Content-Type', mimeType);
}
res.setHeader('Cache-Control', 'no-cache');
res.setHeader('ETag', etag);
res.end(data);

return;
Expand Down