refactor(@angular/build): improve typescript bundling context rebuild checking #28759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
application/prepare-ts-rebuild-control
branch
from
79ae766 to
3014ed7
Compare
clydin
added
the
action: review
clydin
force-pushed
the
application/prepare-ts-rebuild-control
branch
from
3014ed7 to
67c8824
Compare
alan-agius4
reviewed
Nov 1, 2024
packages/angular/build/src/tools/esbuild/angular/component-stylesheets.ts
Outdated
Show resolved
Hide resolved
alan-agius4
reviewed
Nov 1, 2024
packages/angular/build/src/tools/esbuild/bundler-execution-result.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
application/prepare-ts-rebuild-control
branch
from
67c8824 to
1de106f
Compare
alan-agius4
reviewed
Nov 1, 2024
packages/angular/build/src/tools/esbuild/angular/component-stylesheets.ts
Outdated
Show resolved
Hide resolved
… checking The TypeScript-based bundling contexts have now been separated from the other bundling contexts that may be present in an application build. The later of which include global styles, scripts, and non-TypeScript polyfills. This allows for the TypeScript bundling contexts to perform additional checks during a rebuild to determine if they actually need to be rebundled. The bundling context caching for the TypeScript contexts has not yet been enabled but these changes prepare for the switch to allow conditional rebundling on file changes.
clydin
force-pushed
the
application/prepare-ts-rebuild-control
branch
from
1de106f to
80e6b7b
Compare
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript-based bundling contexts have now been separated from the other bundling contexts that may be present in an application build. The later of which include global styles, scripts, and non-TypeScript polyfills. This allows for the TypeScript bundling contexts to perform additional checks during a rebuild to determine if they actually need to be rebundled. The bundling context caching for the TypeScript contexts has not yet been enabled but these changes prepare for the switch to allow conditional rebundling on file changes.