fix(@angular/build): ensure SVG template URLs are considered templates with external stylesheets #28767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with external stylesheets When using the development server with the application builder (default for new projects), the external stylesheet functionality for component style hot replacement was incorrectly considering SVG files as stylesheet resources. This resulted in a build error when using SVG files as a template source. The file extension based checks have now been improved to account for this usage.
clydin
added
action: review
alan-agius4
approved these changes
Nov 1, 2024
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the development server with the application builder (default for new projects), the external stylesheet functionality for component style hot replacement was incorrectly considering SVG files as stylesheet resources. This resulted in a build error when using SVG files as a template source. The file extension based checks have now been improved to account for this usage.