Skip to content

test: add aot option to karma #28854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

test: add aot option to karma #28854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 23 additions & 27 deletions packages/angular_devkit/build_angular/src/builders/karma/tests/options/aot_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ import { execute } from '../../index';
import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeKarmaBuilder } from '../setup';
import { BuilderMode } from '../../schema';

describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget, isApplicationBuilder) => {
describe('Option: "aot"', () => {
it('enables aot with application builder', async () => {
it('enables aot', async () => {
await setupTarget(harness);

await harness.writeFiles({
'src/aot.spec.ts': `
import { Component } from '@angular/core';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Here and in line 44 is some trailing whitespace.

describe('Hello', () => {
it('should *not* contain jit instructions', () => {
@Component({
Expand All @@ -32,48 +32,44 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
`,
});

harness.useTarget('test', {
...BASE_OPTIONS,
aot: true,
/** Cf. {@link ../builder-mode_spec.ts} */
polyfills: ['zone.js', '@angular/localize/init', 'zone.js/testing'],
builderMode: BuilderMode.Application,
});

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();
expect(await runTest({ aot: true })).toBeTrue();
});

it('enables aot with browser builder', async () => {
it('is turned off by default', async () => {
await setupTarget(harness);

await harness.writeFiles({
'src/aot.spec.ts': `
import { Component } from '@angular/core';

describe('Hello', () => {
it('should *not* contain jit instructions', () => {
it('should contain jit instructions', () => {
@Component({
template: 'Hello',
})
class Hello {}

expect((Hello as any).ɵcmp.template.toString()).not.toContain('jit');
expect((Hello as any).ɵcmp.template.toString()).toContain('jit');
});
});
`,
});

harness.useTarget('test', {
...BASE_OPTIONS,
aot: true,
/** Cf. {@link ../builder-mode_spec.ts} */
polyfills: ['zone.js', '@angular/localize/init', 'zone.js/testing'],
builderMode: BuilderMode.Browser,
});

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();
expect(await runTest()).toBeTrue();
});
});

async function runTest({ aot }: { aot?: boolean } = {}) {
harness.useTarget('test', {
...BASE_OPTIONS,
aot,
/** Cf. {@link ../builder-mode_spec.ts} */
polyfills: ['zone.js', '@angular/localize/init', 'zone.js/testing'],
builderMode: isApplicationBuilder ? BuilderMode.Application : BuilderMode.Browser,
});

const { result } = await harness.executeOnce();

return result?.success;
}
});