Skip to content

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Importing PrerenderFallback in a project throws at build time in rc.2 with:

 [ERROR] No matching export in "node_modules/@angular/ssr/fesm2022/ssr.mjs" for import "PrerenderFallback"

    src/app/app.routes.server.ts:1:9:
      1  import { PrerenderFallback, RenderMode, ServerRoute } from '@angula...

What is the new behavior?

This exports PrerenderFallback the same way RenderMode is exported to fix the issue.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Importing `PrerenderFallback` in a project throws at build time in 19.0.0-rc.2 with:

```ts
✘ [ERROR] No matching export in "node_modules/@angular/ssr/fesm2022/ssr.mjs" for import "PrerenderFallback"

    src/app/app.routes.server.ts:1:9:
      1 │ import { PrerenderFallback, RenderMode, ServerRoute } from '@AnGula...
```

This exports `PrerenderFallback` the same way `RenderMode` is exported to fix the issue.
@dgp1130 dgp1130 added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels Nov 15, 2024
@jkrems jkrems merged commit d77527d into angular:main Nov 15, 2024
34 checks passed
@jkrems
Copy link
Contributor

jkrems commented Nov 15, 2024

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants