refactor: removes @angular/ssr/tokens and imports the symbols from @angular/core
#28871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgp1130
added
action: review
AndrewKushnir
approved these changes
Nov 15, 2024
|
Sorry for that, looks like my merge of the angular bot generated version bumps created a conflict here. |
…`@angular/core` Since the symbols are exposed from `@angular/core`, there is no need for a separate export in `@angular/ssr/tokens` anymore.
|
No problem, just rebased and dropped the version bump. |
jkrems
approved these changes
Nov 15, 2024
jkrems
added
action: merge
|
Switched |
|
@jkrems, SGTM feel free to merge once CI passes. |
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the symbols are exposed from
@angular/core, there is no need for a separate export in@angular/ssr/tokensanymore.