Skip to content

refactor(@angular/build): adjust code to propagate errors from Piscina #28918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

refactor(@angular/build): adjust code to propagate errors from Piscina #28918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions packages/angular/build/src/utils/server-rendering/routes-extractor-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ const { outputMode, hasSsrEntry } = workerData as {
hasSsrEntry: boolean;
};

let serverURL = DEFAULT_URL;

/** Renders an application based on a provided options. */
async function extractRoutes(): Promise<RoutersExtractorWorkerResult> {
const serverURL = outputMode !== undefined && hasSsrEntry ? await launchServer() : DEFAULT_URL;

patchFetchToLoadInMemoryAssets(serverURL);

const { ɵextractRoutesAndCreateRouteTree: extractRoutesAndCreateRouteTree } =
await loadEsmModuleFromMemory('./main.server.mjs');

Expand All @@ -47,14 +49,4 @@ async function extractRoutes(): Promise<RoutersExtractorWorkerResult> {
};
}

async function initialize() {
if (outputMode !== undefined && hasSsrEntry) {
serverURL = await launchServer();
}

patchFetchToLoadInMemoryAssets(serverURL);

return extractRoutes;
}

export default initialize();
export default extractRoutes;