Skip to content

Conversation

wkaskie
Copy link

@wkaskie wkaskie commented Nov 26, 2024

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [ x ] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, enabling SRI will default to the sha384 algorithm. This is not always available on the server (s3 supports up to sha256, for example.)

Issue Number: 28946

What is the new behavior?

The modifications expose a new configuration property to match that of the webpack-subresource-integrity hashFuncNames which accepts an array of strings, leveraging the highest available. This allows users to set sha256 or sha512.

Does this PR introduce a breaking change?

  • Yes
  • [ x ] No

Other information

Copy link

google-cla bot commented Nov 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: @angular/cli labels Nov 26, 2024
@wkaskie
Copy link
Author

wkaskie commented Nov 26, 2024

I signed the CLA before creating the MR. Please advise.

Screenshot 2024-11-26 at 9 46 12 AM

@wkaskie wkaskie force-pushed the wkaskie/CustomSriHash branch from 156f079 to b995055 Compare November 26, 2024 14:54
@wkaskie
Copy link
Author

wkaskie commented Nov 26, 2024

I've updated the email address in the commit and made the email address public in my gitHub account

@wkaskie
Copy link
Author

wkaskie commented Nov 26, 2024

Closing to resubmit with the updated Author information

@wkaskie wkaskie closed this Nov 26, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: @angular/cli detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant