Skip to content

Conversation

crisbeto
Copy link
Member

Updates the repo to use TypeScript 5.7.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 28, 2024
@crisbeto crisbeto force-pushed the ts-5.7 branch 10 times, most recently from 0cf1c64 to b042878 Compare November 29, 2024 07:52
@crisbeto crisbeto force-pushed the ts-5.7 branch 3 times, most recently from 0d360b4 to 9c1750d Compare December 2, 2024 08:39
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Dec 2, 2024
@crisbeto crisbeto marked this pull request as ready for review December 2, 2024 09:29
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These peer dependencies are not valid.

The string value need to be an exact match to ^19.0.0 || ^19.1.0-next.0, any other value is not valid and will cause the release checks to fail.

I have a PR to bump the packages #29007

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 2, 2024
@crisbeto
Copy link
Member Author

crisbeto commented Dec 2, 2024

This won't allow any other 19.0.x versions though (e.g. 19.0.1). I think the right thing to do is to require only 19.1.x in the next minor.

@alan-agius4
Copy link
Collaborator

Sorry I was meant to be ^19.0.0 || ^19.1.0-next.0

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are a couple of places where typescript has not been updated.

packages/angular_devkit/schematics_cli/blank/project-files/package.json
packages/angular_devkit/schematics_cli/schematic/files/package.json

Updates the repo to use TypeScript 5.7.
@crisbeto
Copy link
Member Author

crisbeto commented Dec 2, 2024

Should be ready to go now.

@crisbeto crisbeto removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 2, 2024
@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 2, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 2, 2024
@alan-agius4 alan-agius4 merged commit 4d466bf into angular:main Dec 2, 2024
32 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants