Skip to content

test: Introduce delay for file write to minimize flakiness #29050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: Introduce delay for file write to minimize flakiness #29050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533fd21
test: Introduce delay for file write to minimize flakiness
alan-agius4 Dec 4, 2024
9b9ae1a
Revert "test: Introduce delay for file write to minimize flakiness"
alan-agius4 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/legacy-cli/e2e/tests/vite/ssr-new-dep-optimization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import assert from 'node:assert';
import { setTimeout } from 'node:timers/promises';
import { ng, waitForAnyProcessOutputToMatch } from '../../utils/process';
import { installWorkspacePackages, uninstallPackage } from '../../utils/packages';
import { ngServe, useSha } from '../../utils/project';
Expand All @@ -25,17 +24,18 @@ export default async function () {
const port = await ngServe();
await validateResponse('/', /Hello,/);

const appConfigContentsUpdated = `
import { provideAnimationsAsync } from '@angular/platform-browser/animations/async';
${(await readFile('src/app/app.config.ts')).replace('provideRouter(routes),', 'provideAnimationsAsync(), provideRouter(routes),')}
`;

await Promise.all([
waitForAnyProcessOutputToMatch(
/new dependencies optimized: @angular\/platform-browser\/animations\/async/,
6000,
),
setTimeout(200).then(() => writeFile('src/app/app.config.ts', appConfigContentsUpdated)),
writeFile(
'src/app/app.config.ts',
`
import { provideAnimationsAsync } from '@angular/platform-browser/animations/async';
${(await readFile('src/app/app.config.ts')).replace('provideRouter(routes),', 'provideAnimationsAsync(), provideRouter(routes),')}
`,
),
]);

// Verify the app still works.
Expand Down
Loading