fix(@angular-devkit/build-angular): webpack config transform for karma #29066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
added
action: review
jkrems
force-pushed
the
jk-karma-wp-transform
branch
from
9fae909 to
a414a99
Compare
jkrems
force-pushed
the
jk-karma-wp-transform
branch
from
a414a99 to
ce74a2d
Compare
clydin
approved these changes
Dec 5, 2024
jkrems
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is 10% passing an argument that got dropped during refactoring and 90% finding a way to test the behavior.
I'm making up a new concept for the harness (
additionalExecuteArguments) which is pretty ugly but I couldn't think of a cleaner way of doing it. There might be a way to capture rest arguments of theexecutefunction signature inside of the harness to make the cast go away. But I'm not 100% convinced that the more complicated types leaking throughout the harness code would really be worth it for this edge case.See: #29003