Skip to content

refactor(@angular/build): add globalThis['ngServerMode'] only when externalDependencies are present #29100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

refactor(@angular/build): add globalThis['ngServerMode'] only when externalDependencies are present #29100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/angular/build/src/tools/esbuild/application-code-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,11 @@ export function createServerPolyfillBundleOptions(
return;
}

const jsBanner: string[] = [`globalThis['ngServerMode'] = true;`];
const jsBanner: string[] = [];
if (polyfillBundleOptions.external?.length) {
jsBanner.push(`globalThis['ngServerMode'] = true;`);
}

if (isNodePlatform) {
// Note: Needed as esbuild does not provide require shims / proxy from ESModules.
// See: https://github.com/evanw/esbuild/issues/1921.
Expand Down Expand Up @@ -394,7 +398,11 @@ export function createSsrEntryCodeBundleOptions(
const ssrInjectManifestNamespace = 'angular:ssr-entry-inject-manifest';
const isNodePlatform = options.ssrOptions?.platform !== ExperimentalPlatform.Neutral;

const jsBanner: string[] = [`globalThis['ngServerMode'] = true;`];
const jsBanner: string[] = [];
if (options.externalDependencies?.length) {
jsBanner.push(`globalThis['ngServerMode'] = true;`);
}

if (isNodePlatform) {
// Note: Needed as esbuild does not provide require shims / proxy from ESModules.
// See: https://github.com/evanw/esbuild/issues/1921.
Expand Down
Loading