Skip to content

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the new behavior?

Now that signals are recommended, this updates the generated AppComponent to use a signal for the title field.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 requested a review from alxhub December 11, 2024 13:51
@cexbrayat cexbrayat force-pushed the feat/use-signal branch 2 times, most recently from db677fc to f849d0c Compare June 3, 2025 21:50
This updates the generated `App` component to use a signal for the `title` field.
@cexbrayat
Copy link
Member Author

@alan-agius4 @dgp1130 PR is ready for review with your feedback

Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating.

@alan-agius4, is there anything else we need to update, or should this be sufficient?

@dgp1130 dgp1130 added target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 5, 2025
@dgp1130 dgp1130 removed the request for review from alxhub June 5, 2025 17:05
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 6, 2025
@dgp1130 dgp1130 merged commit 1c19e0d into angular:main Jun 6, 2025
33 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Jun 6, 2025

Thanks for the contribution, apologies for the long delay on this!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants