Skip to content

refactor(@angular/ssr): add timeout to prevent 'adev' hanging during route extraction #29143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

refactor(@angular/ssr): add timeout to prevent 'adev' hanging during route extraction #29143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/angular/ssr/src/routes/ng-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,10 @@ export async function getRoutesFromAngularRouterConfig(
}
}

// This timeout is necessary to prevent 'adev' from hanging in production builds.
// The exact cause is unclear, but removing it leads to the issue.
await new Promise((resolve) => setTimeout(resolve, 0));

if (serverConfigRouteTree) {
for (const { route, presentInClientRouter } of serverConfigRouteTree.traverse()) {
if (presentInClientRouter || route === '**') {
Expand Down
Loading