Skip to content

Conversation

alan-agius4
Copy link
Collaborator

This const is pure.

@alan-agius4 alan-agius4 requested a review from dgp1130 December 17, 2024 13:54
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 17, 2024
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How exactly does marking this pure help us? Does it allow this string to be pruned from bundles when unused or something like that?

@alan-agius4
Copy link
Collaborator Author

How exactly does marking this pure help us? Does it allow this string to be pruned from bundles when unused or something like that?

Yes

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 17, 2024
@dgp1130 dgp1130 merged commit f7c0a83 into angular:main Dec 17, 2024
34 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Dec 17, 2024

The changes were merged into the following branches: main, 19.0.x

@alan-agius4 alan-agius4 deleted the refactor-pure-inline branch December 17, 2024 19:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants