Skip to content

ci: ensure passing build before rest of PR jobs #29208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2024
Merged

ci: ensure passing build before rest of PR jobs #29208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
retention-days: 14

test:
needs: build
runs-on: ubuntu-latest
steps:
- name: Initialize environment
Expand All @@ -103,6 +104,7 @@ jobs:
ASPECT_RULES_JS_FROZEN_PNPM_LOCK: '1'

e2e:
needs: build
strategy:
fail-fast: false
matrix:
Expand All @@ -124,6 +126,7 @@ jobs:
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}

e2e-windows-subset:
needs: build
runs-on: windows-latest
steps:
# Workaround for: https://github.com/bazel-contrib/bazel-lib/issues/968.
Expand All @@ -141,6 +144,7 @@ jobs:
run: yarn bazel test --config=e2e //tests/legacy-cli:e2e_node22 --test_filter="tests/basic/{build,rebuild}.ts" --test_arg="--esbuild"

e2e-package-managers:
needs: build
strategy:
fail-fast: false
matrix:
Expand All @@ -162,7 +166,7 @@ jobs:
run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}

e2e-snapshots:
needs: analyze
needs: [analyze, build]
if: needs.analyze.outputs.snapshots == 'true'
strategy:
fail-fast: false
Expand Down
Loading