Skip to content

Conversation

43081j
Copy link

@43081j 43081j commented Dec 25, 2024

Migrates from ora to picospinner for CLI spinners.

This is a much lighter and faster package, giving us some gains in performance.

Note that most popular spinner libraries are meant to ignore/clear output while they are running. So previous workarounds and notes around that will need to be re-discussed.

I'm leaving this a draft until we have discussed the above point

PR Checklist

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Migrates from `ora` to `picospinner` for CLI spinners.

This is a much lighter and faster package, giving us some gains in
performance.

Note that most popular spinner libraries are _meant_ to ignore/clear
output while they are running. So previous workarounds and notes around
that will need to be re-discussed.
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Jan 6, 2025

Thank you for this! However, we have already begun transitioning from ora to listr2.

@alan-agius4 alan-agius4 closed this Jan 6, 2025
@43081j
Copy link
Author

43081j commented Jan 6, 2025

Sounds good to me!

Got a PR or issue we can follow?

@43081j 43081j deleted the spinner-fluff branch January 6, 2025 09:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants