Skip to content

Conversation

santoshyadavdev
Copy link
Contributor

Fixes #29040

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #29040

What is the new behavior?

It uses kb value from packages/angular/build/src/utils/bundle-calculator.ts so there is no difference in value when running tests

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@santoshyadavdev santoshyadavdev force-pushed the fix-incorect-budget-warning branch from 656defa to 3394f77 Compare December 28, 2024 17:11
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release merge: squash commits When the PR is merged, a squash and merge should be performed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed and removed merge: squash commits When the PR is merged, a squash and merge should be performed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jan 6, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this just a couple of NITs.

The commit scope should be @angular/build and not @angular-devkit/build-angular and please add a commit message body. https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 6, 2025
@santoshyadavdev santoshyadavdev force-pushed the fix-incorect-budget-warning branch from 3394f77 to 27710bb Compare January 7, 2025 15:50
@angular-robot angular-robot bot requested a review from alan-agius4 January 7, 2025 15:50
@santoshyadavdev santoshyadavdev force-pushed the fix-incorect-budget-warning branch 2 times, most recently from 5f49618 to ae19e25 Compare January 7, 2025 15:53
This PR makes change to kB value which was incorrect earlier

Fixes angular#29040
@santoshyadavdev santoshyadavdev force-pushed the fix-incorect-budget-warning branch from ae19e25 to 40ff0c2 Compare January 8, 2025 09:48
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 8, 2025
@santoshyadavdev santoshyadavdev changed the title fix(@angular-devkit/build-angular) : fix incorrect budget calculation fix(@angular/build) : fix incorrect budget calculation Jan 8, 2025
@jkrems jkrems merged commit e76800c into angular:main Jan 8, 2025
31 checks passed
@jkrems
Copy link
Contributor

jkrems commented Jan 8, 2025

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Budget warnings calculated incorrectly with esbuild builder

3 participants