-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/build): do not mark Babel _defineProperty helper function as pure #29250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bac5d43 to
d9cbfcb
Compare
d9cbfcb to
3bdc9c3
Compare
packages/angular/build/src/tools/babel/plugins/pure-toplevel-functions.ts
Outdated
Show resolved
Hide resolved
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one NIT
3bdc9c3 to
46c1622
Compare
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #29145
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
_defineProperty is marked as pure and then tree shaken when targeting Safari < 15 or Chrome < 84 which breaks the application.
Issue Number: #29145
What is the new behavior?
_defineProperty is not marked as pure
Does this PR introduce a breaking change?
Other information