Skip to content

build: resolve issue with uncompiled @angular/build/private being included #29280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

build: resolve issue with uncompiled @angular/build/private being included #29280

merged 1 commit into from
Jan 8, 2025

Conversation

alan-agius4
Copy link
Collaborator

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 8, 2025
@alan-agius4 alan-agius4 requested a review from devversion January 8, 2025 12:13
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 8, 2025
alan-agius4
alan-agius4 commented Jan 8, 2025
View reviewed changes
packages/angular/build/BUILD.bazel
":build",
":license",
":private",
"//packages/angular/build/private",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devversion, do you know why the full label is needed?

@devversion
Copy link
Member

I'm currently investigating that as well, not sure yet

devversion
devversion approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a Bazel bug as it in practice just ends up referencing the directory 😄 Fix LGTM and is the correct idiomatic solution

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 8, 2025
@alan-agius4 alan-agius4 merged commit e66b24b into angular:main Jan 8, 2025
34 checks passed
@alan-agius4 alan-agius4 deleted the compile-private-build branch January 8, 2025 12:47
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-agius4 @devversion