Skip to content

build: migrate @angular/create to npm_package #29324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

build: migrate @angular/create to npm_package #29324

merged 1 commit into from
Jan 13, 2025

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jan 10, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 10, 2025
@clydin clydin added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jan 10, 2025
@josephperrott josephperrott force-pushed the migrate-package branch 3 times, most recently from a8a5db5 to 06448a8 Compare January 10, 2025 17:05
devversion
devversion approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@devversion devversion added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 10, 2025
@josephperrott josephperrott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 13, 2025
@josephperrott
build: migrate @angular/create to npm_package
c18cb96 
This allows us to use the package in the RJS pnpm workspace.
@dgp1130 dgp1130 removed the request for review from clydin January 13, 2025 20:59
@dgp1130 dgp1130 merged commit a7155f6 into angular:main Jan 13, 2025
30 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Jan 13, 2025

The changes were merged into the following branches: main, 19.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2025
@josephperrott josephperrott deleted the migrate-package branch February 14, 2025 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@josephperrott @dgp1130 @devversion @alan-agius4 @clydin