Skip to content

fix(@angular/build): warn when using both isolatedModules and emitDecoratorMetadata #29345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(@angular/build): warn when using both isolatedModules and emitDecoratorMetadata #29345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/angular/build/src/tools/esbuild/angular/compiler-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,20 @@ function createCompilerOptionsTransformer(
});
}

if (compilerOptions.isolatedModules && compilerOptions.emitDecoratorMetadata) {
setupWarnings?.push({
text: `TypeScript compiler option 'isolatedModules' may prevent the 'emitDecoratorMetadata' option from emitting all metadata.`,
location: null,
notes: [
{
text:
`The 'emitDecoratorMetadata' option is not required by Angular` +
'and can be removed if not explictly required by the project.',
},
],
});
}

// Synchronize custom resolve conditions.
// Set if using the supported bundler resolution mode (bundler is the default in new projects)
if (compilerOptions.moduleResolution === 100 /* ModuleResolutionKind.Bundler */) {
Expand Down
Loading