build: replace hardcoded Angular and ng-packagr peer dependencies with Bazel stamping #29368
Conversation
alan-agius4
added
the
action: review
alan-agius4
added
the
target: minor
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
stamping-versions
branch
2 times, most recently
from
2e1697b to
5451a08
Compare
There was a problem hiding this comment.
This is great, thanks @alan-agius4! I've wanted something like this for a while now, glad to see it's possible with @aspect_rules_js!
constants.bzl
Outdated
| RELEASE_ENGINES_YARN = ">= 1.13.0" | ||
|
|
||
| NG_PACKAGR_VERSION = "^19.1.0-next.0" | ||
| ANGULAR_VERSION = "^19.1.0-next.0" |
There was a problem hiding this comment.
Question: What exactly does ANGULAR_VERSION represent? The @angular/core / FW version used for direct dependencies? I wonder if a more specific name like ANGULAR_FW_VERSION might be helpful to communicate its purpose.
There was a problem hiding this comment.
Yes, it reflects the version of the @angular/ packages specified in the user's package.json when they run ng new.
Note: This functionality was also possible with the old setup.
…h Bazel stamping Refactor the build configuration to use Bazel stamping for Angular and ng-packagr dependencies, eliminating the need for hardcoded peer dependencies.
alan-agius4
force-pushed
the
stamping-versions
branch
from
5451a08 to
168f967
Compare
alan-agius4
added
action: merge
This is current checking `packages/schematics/angular/utility/latest-versions/package.json` but recently we change how the version is set angular#29368
This is current checking `packages/schematics/angular/utility/latest-versions/package.json` but recently we change how the version is set angular#29368
This is current checking `packages/schematics/angular/utility/latest-versions/package.json` but recently we change how the version is set #29368
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
Refactor the build configuration to use Bazel stamping for Angular and ng-packagr dependencies, eliminating the need for hardcoded peer dependencies.