Skip to content

fix(@angular/build): perform full reload for templates with $localize usage #29405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(@angular/build): perform full reload for templates with $localize usage #29405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/angular/build/src/tools/angular/compilation/aot-compilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ export class AotCompilation extends AngularCompilation {
`${host.getCanonicalFileName(relativePath)}@${node.name?.text}`,
);
const updateText = angularCompiler.emitHmrUpdateModule(node);
if (updateText === null) {
// If compiler cannot generate an update for the component, prevent template updates.
// Also prevent template updates if $localize is directly present which also currently
// prevents a template update at runtime.
// TODO: Support localized template update modules and remove this check.
if (updateText === null || updateText.includes('$localize')) {
// Build is needed if a template cannot be updated
templateUpdates = undefined;
break;
Expand Down
Loading