Migrate more tests to rules_js
#29433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates the sub-entry point tests for architect/node to `rules_js`.
angular-robot
bot
added
the
area: build & ci
alan-agius4
reviewed
Jan 21, 2025
Migrates the sub-entry point tests for core/node to `rules_js`.
Migrates the sub-entry point tests for ngtools/webpack to `rules_js`.
Migrates the sub-entry point tests for schematics/tools to `rules_js`.
Migrates the schematics-cli tests to `rules_js`. Notably a little extra logic was needed here as the tests were relying on the built npm package at runtime, resolvable via it's "package name". To address this, we manually link the package for the test at runtime. The spec file is moved into a separate folder for this reason, so that we don't accidentally expose the schematics CLI package for unexpected reasons.
Migrates the @schematics/angular tests to `rules_js`.
devversion
added
the
action: review
…inting Excludes CLI workspace projects from main project/IDE tsconfig to speed up language service actions and linting. Those files should not be considered part of the development sources.
alan-agius4
approved these changes
Jan 21, 2025
devversion
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely the second last PR to migrate tests to
rules_js. One left after this one.