fix(@angular/ssr): rename provideServerRoutesConfig to provideServerRouting
#29473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
server-routing-api
branch
2 times, most recently
from
a10ab40 to
19c8f5e
Compare
alan-agius4
added
the
action: review
dgp1130
reviewed
Jan 25, 2025
…erRouting`
This commit renames `provideServerRoutesConfig` to `provideServerRouting` and updates the second parameter to use the `ServerRoutes` features.
This change improves alignment with the framework's API conventions and the way features are integrated.
### Example Usage:
Before:
```typescript
provideServerRoutesConfig(serverRoutes, { appShellRoute: 'shell' })
```
After:
```typescript
provideServerRouting(serverRoutes, withAppShell(AppShellComponent))
```
alan-agius4
force-pushed
the
server-routing-api
branch
from
19c8f5e to
bc5ed9a
Compare
alan-agius4
added
the
target: patch
dgp1130
approved these changes
Jan 27, 2025
alan-agius4
added
action: merge
Collaborator
Author
|
The changes were merged into the following branches: main, 19.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames
provideServerRoutesConfigtoprovideServerRoutingand updates the second parameter to use theServerRoutesfeatures.This change improves alignment with the framework's API conventions and the way features are integrated.
Example Usage:
Before:
After: