Skip to content

fix(@angular/build): disable TypeScript removeComments option #29474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix(@angular/build): disable TypeScript removeComments option #29474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/angular/build/src/tools/angular/compilation/angular-compilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ export abstract class AngularCompilation {
enableResourceInlining: false,
supportTestBed: false,
supportJitMode: false,
// Disable removing of comments as TS is quite aggressive with these and can
// remove important annotations, such as /* @__PURE__ */ and comments like /* vite-ignore */.
removeComments: false,
}),
);
}
Expand Down
3 changes: 3 additions & 0 deletions packages/angular_devkit/build_angular/src/tools/webpack/plugins/typescript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ export function createIvyPlugin(
sourceMap: buildOptions.sourceMap.scripts,
declaration: false,
declarationMap: false,
// Disable removing of comments as TS is quite aggressive with these and can
// remove important annotations, such as /* @__PURE__ */.
removeComments: false,
};

if (tsConfig.options.target === undefined || tsConfig.options.target < ScriptTarget.ES2022) {
Expand Down
Loading