build: re-enable latest version checks during release #29545
Conversation
alan-agius4
added
action: review
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
version-checks
branch
2 times, most recently
from
07aec9a to
622640b
Compare
| // Root of the Angular CLI project. | ||
| const root = fileURLToPath(new URL('../../../', import.meta.url)); | ||
| const rootRequire = createRequire(root); | ||
| const { latestVersions } = rootRequire('./dist/@schematics/angular/utility/latest-versions.js'); |
There was a problem hiding this comment.
Is dist/ guaranteed to be existent here? Seems like an assumption that is potentially brittle. Also the createRequire is not super great :(
There was a problem hiding this comment.
Yes, the NPM packages are always built in the dist, I did noticed that I was not reading from the release directory though which I amended.
Regarding createRequire, I agree that using a RegExp could work. However, I lean toward this approach since it minimizes the risk of false positives or negatives.
There was a problem hiding this comment.
Yeah, definitely agreed on it being better than a RegExp.
There was a problem hiding this comment.
Ideally we'd somehow pass the packages and their artifact paths to the pre=release checks, but that's not possible right now, so LGTM
This commit restores the latest version checks, which are now fixed by using the stamped versions.
alan-agius4
force-pushed
the
version-checks
branch
from
622640b to
589f01e
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
This commit restores the latest version checks, which are now fixed by using the stamped versions.