Skip to content

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Feb 3, 2025

If the chunk happens to end in a new line or other meaningful whitespace, stripping it can lead to two words (e.g. targets) being squished together and broken.

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

If the chunk happens to end in a new line or other meaningful
whitespace, stripping it can lead to two words (e.g. targets)
being squished together and broken.
@jkrems jkrems requested a review from alan-agius4 February 3, 2025 20:35
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Feb 3, 2025
@jkrems
Copy link
Contributor Author

jkrems commented Feb 3, 2025

@jkrems jkrems requested a review from dgp1130 February 3, 2025 21:31
@jkrems jkrems added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 3, 2025
@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 3, 2025
@alan-agius4 alan-agius4 removed the request for review from dgp1130 February 3, 2025 22:16
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 3, 2025
@jkrems jkrems merged commit c48a2da into angular:main Feb 3, 2025
34 checks passed
@jkrems
Copy link
Contributor Author

jkrems commented Feb 3, 2025

The changes were merged into the following branches: main, 19.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2025
@jkrems jkrems deleted the fix-build-schema branch August 20, 2025 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants