fix(@schematics/angular): remove animations module from ng new app #29618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
ng-new-animations
branch
5 times, most recently
from
f7f63eb to
78dbe18
Compare
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
crisbeto
force-pushed
the
ng-new-animations
branch
from
78dbe18 to
0e5b42a
Compare
crisbeto
commented
Feb 12, 2025
...cy-cli/e2e/tests/build/server-rendering/server-routes-output-mode-server-platform-neutral.ts
Show resolved
Hide resolved
crisbeto
added
action: review
alan-agius4
approved these changes
Feb 12, 2025
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the animations module was added to the
ng newapp, becauseplatform-serverwas using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.