Skip to content

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Feb 25, 2025

Manual changes:

  • npx @eslint/migrate-config .eslintrc.json.
  • Disable reportUnusedDisableDirectives.
  • Patch the header plugin as mentioned in the upstream issue.

Doing this now since other packages start requiring eslint@9 (#29660).

@jkrems jkrems requested a review from dgp1130 February 25, 2025 01:08
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Feb 25, 2025
@jkrems jkrems added target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels Feb 25, 2025
@jkrems jkrems force-pushed the eslint9 branch 2 times, most recently from 87de313 to 1086bd0 Compare February 25, 2025 01:18
@jkrems jkrems added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 25, 2025
@jkrems jkrems added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 25, 2025
@ngbot

This comment was marked as outdated.

Manual changes:

* `npx @eslint/migrate-config .eslintrc.json`.
* Disable `reportUnusedDisableDirectives`.
* Patch the `header` plugin as mentioned in the upstream issue.
@jkrems jkrems merged commit 1151c98 into angular:main Feb 25, 2025
30 checks passed
@jkrems jkrems deleted the eslint9 branch February 25, 2025 18:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants