fix(@angular/build): allow component HMR with a service worker #29723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the service worker option is enabled, each code update will cause the `ngsw.json` configuration file to change due to the different hashes of the updated output. This is problematic for component HMR usage with the development server since the full reload fallback logic would be triggered due to the changed `ngsw.json` file. To avoid this problem, the `ngsw.json` configuration file is now special cased within the fallback logic.
clydin
force-pushed
the
hmr/service-worker-compat
branch
from
1fc8282 to
7c78c66
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Mar 4, 2025
alan-agius4
added
action: merge
Collaborator
|
The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the service worker option is enabled, each code update will cause the
ngsw.jsonconfiguration file to change due to the different hashes of the updated output. This is problematic for component HMR usage with the development server since the full reload fallback logic would be triggered due to the changedngsw.jsonfile. To avoid this problem, thengsw.jsonconfiguration file is now special cased within the fallback logic.