Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Feb 28, 2025

Usage of the fast-glob package has been replaced with the tinyglobby package throughout @angular/build. The change reduces the number of transitive dependencies related to these packages from 17 to 2 while also maintaining equivalent functionality. Additionally, the tinyglobby package is used by other dependencies such as vite and copy-webpack-plugin which has the potential to further reduce overall transitive dependencies for a project.

@clydin clydin added the target: major This PR is targeted for the next major release label Feb 28, 2025
@clydin clydin marked this pull request as ready for review February 28, 2025 17:35
@clydin clydin force-pushed the build/tinyglobby-usage branch from 4b76376 to ee01d22 Compare March 1, 2025 00:08
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 3, 2025
@ngbot
Copy link

ngbot bot commented Mar 3, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure conflicts with base branch "main"
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 3, 2025
Usage of the `fast-glob` package has been replaced with the `tinyglobby`
package throughout `@angular/build`. The change reduces the number of
transitive dependencies related to these packages from 17 to 2 while
also maintaining equivalent functionality. Additionally, the `tinyglobby`
package is used by other dependencies such as `vite` and `copy-webpack-plugin`
which has the potential to further reduce overall transitive dependencies
for a project.
@clydin clydin force-pushed the build/tinyglobby-usage branch from ee01d22 to e9e0921 Compare March 3, 2025 15:30
@clydin clydin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 3, 2025
@alan-agius4 alan-agius4 merged commit c39c344 into angular:main Mar 3, 2025
30 checks passed
@clydin clydin deleted the build/tinyglobby-usage branch March 3, 2025 15:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants