feat(@angular/build): integrate Chrome automatic workspace folders #29757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
angular-robot
bot
added
detected: feature
alan-agius4
force-pushed
the
chrome-workspaces
branch
4 times, most recently
from
40743e4 to
71386d4
Compare
clydin
approved these changes
Mar 5, 2025
packages/angular/build/src/tools/vite/middlewares/chrome-devtools-middleware.ts
Outdated
Show resolved
Hide resolved
This commit integrates automatic Chrome DevTools workspace folder connection into the vite dev-server process, leveraging the experimental feature available in Chrome Canary, as described in the Chrome DevTools documentation https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/ecosystem/automatic_workspace_folders.md
alan-agius4
force-pushed
the
chrome-workspaces
branch
from
71386d4 to
9120171
Compare
alan-agius4
added
action: merge
bmeurer
reviewed
Mar 11, 2025
|
|
||
| // We store the UUID and re-use it to ensure Chrome does not repeatedly ask for permissions when restarting the dev server. | ||
| try { | ||
| devtoolsConfig ??= readFileSync(devtoolsConfigPath, 'utf-8'); |
There was a problem hiding this comment.
Maybe I'm missing something, but what happens if you relocate the project folder? That doesn't seem to trigger deletion of the cached file.
There was a problem hiding this comment.
That is correct, we could add a check here to validate that the path is the same otherwise we could re-generate the entry.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit integrates automatic Chrome DevTools workspace folder connection into the vite dev-server process, leveraging the experimental feature available in Chrome Canary, as described in the Chrome DevTools documentation https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/ecosystem/automatic_workspace_folders.md