refactor(@angular/build): define an internal ngHmrMode value #29828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An `ngHmrMode` boolean value will now be defined within application bundles. The value is based on the development server's `hmr` option with `true` when HMR is enabled and `false` when disabled. For all application builds, the value will be `false`. `ngHmrMode` is similar in behavior to `ngServeMode` or `ngDevMode`. It will not be present in the output code unless referenced and in those cases only the final boolean value will be present if not optimized out of the final code. The value is not considered part of the public API and may change in the future.
clydin
force-pushed
the
dev/ng-hmr-mode-define
branch
from
064924d to
7b16cd6
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Mar 13, 2025
clydin
added
target: patch
|
The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
ngHmrModeboolean value will now be defined within application bundles. The value is based on the development server'shmroption withtruewhen HMR is enabled andfalsewhen disabled. For all application builds, the value will befalse.ngHmrModeis similar in behavior tongServeModeorngDevMode. It will not be present in the output code unless referenced and in those cases only the final boolean value will be present if not optimized out of the final code.The value is not considered part of the public API and may change in the future.