Skip to content

build: avoid WSL interop flake when preparing Windows CI environment #29831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

build: avoid WSL interop flake when preparing Windows CI environment #29831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion scripts/windows-testing/convert-symlinks.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,22 @@ async function transformDir(p) {
}
}

function exec(cmd) {
function exec(cmd, maxRetries = 2) {
return new Promise((resolve, reject) => {
childProcess.exec(cmd, { cwd: rootDir }, (error) => {
if (error !== null) {
// Windows command spawned within WSL (which is untypical) seem to be flaky rarely.
// This logic tries to make it fully stable by re-trying if this surfaces:
// See: https://github.com/microsoft/WSL/issues/8677.
if (
maxRetries > 0 &&
error.stderr !== undefined &&
error.stderr.includes(`accept4 failed 110`)
) {
resolve(exec(cmd, maxRetries - 1));
return;
}

reject(error);
} else {
resolve();
Expand Down