Skip to content

build: move devkit core specific dependencies out of root #29868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

build: move devkit core specific dependencies out of root #29868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,11 @@
"@typescript-eslint/parser": "8.26.1",
"@web/test-runner": "^0.20.0",
"ajv": "8.17.1",
"ajv-formats": "3.0.1",
"ansi-colors": "4.1.3",
"beasties": "0.2.0",
"browser-sync": "3.0.3",
"browserslist": "^4.21.5",
"buffer": "6.0.3",
"chokidar": "4.0.3",
"esbuild": "0.25.1",
"esbuild-wasm": "0.25.1",
"eslint": "9.22.0",
Expand All @@ -130,7 +128,6 @@
"jasmine-core": "~5.6.0",
"jasmine-reporters": "^2.5.2",
"jasmine-spec-reporter": "~7.0.0",
"jsonc-parser": "3.3.1",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
Expand All @@ -148,7 +145,6 @@
"open": "10.1.0",
"ora": "5.4.1",
"parse5-html-rewriting-stream": "7.0.0",
"picomatch": "4.0.2",
"piscina": "4.9.0",
"postcss": "8.5.3",
"prettier": "^3.0.0",
Expand All @@ -162,7 +158,6 @@
"sass": "1.85.1",
"semver": "7.7.1",
"shelljs": "^0.9.0",
"source-map": "0.7.4",
"source-map-support": "0.5.21",
"symbol-observable": "4.0.0",
"tar": "^7.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/build/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ ts_project(
":node_modules/@angular/ssr",
":node_modules/@inquirer/confirm",
":node_modules/@vitejs/plugin-basic-ssl",
":node_modules/jsonc-parser",
":node_modules/picomatch",
":node_modules/vite",
"//:node_modules/@ampproject/remapping",
"//:node_modules/@angular/common",
Expand All @@ -105,7 +107,6 @@ ts_project(
"//:node_modules/esbuild-wasm",
"//:node_modules/https-proxy-agent",
"//:node_modules/istanbul-lib-instrument",
"//:node_modules/jsonc-parser",
"//:node_modules/karma",
"//:node_modules/less",
"//:node_modules/listr2",
Expand All @@ -114,7 +115,6 @@ ts_project(
"//:node_modules/mrmime",
"//:node_modules/ng-packagr",
"//:node_modules/parse5-html-rewriting-stream",
"//:node_modules/picomatch",
"//:node_modules/piscina",
"//:node_modules/postcss",
"//:node_modules/rollup",
Expand Down
1 change: 1 addition & 0 deletions packages/angular/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"esbuild": "0.25.1",
"https-proxy-agent": "7.0.6",
"istanbul-lib-instrument": "6.0.3",
"jsonc-parser": "3.3.1",
"listr2": "8.2.5",
"magic-string": "0.30.17",
"mrmime": "2.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/cli/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ ts_project(
":node_modules/@listr2/prompt-adapter-inquirer",
":node_modules/@yarnpkg/lockfile",
":node_modules/ini",
":node_modules/jsonc-parser",
":node_modules/npm-package-arg",
":node_modules/npm-pick-manifest",
":node_modules/pacote",
Expand All @@ -66,7 +67,6 @@ ts_project(
"//:node_modules/@types/semver",
"//:node_modules/@types/yargs",
"//:node_modules/@types/yarnpkg__lockfile",
"//:node_modules/jsonc-parser",
"//:node_modules/listr2",
"//:node_modules/semver",
"//:node_modules/symbol-observable",
Expand Down
5 changes: 2 additions & 3 deletions packages/angular_devkit/build_angular/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ ts_project(
":node_modules/@babel/runtime",
":node_modules/@discoveryjs/json-ext",
":node_modules/@ngtools/webpack",
":node_modules/@vitejs/plugin-basic-ssl",
":node_modules/autoprefixer",
":node_modules/babel-loader",
":node_modules/copy-webpack-plugin",
":node_modules/css-loader",
":node_modules/jsonc-parser",
":node_modules/less",
":node_modules/less-loader",
":node_modules/license-webpack-plugin",
Expand Down Expand Up @@ -183,7 +183,6 @@ ts_project(
"//:node_modules/@types/semver",
"//:node_modules/@types/watchpack",
"//:node_modules/@web/test-runner",
"//:node_modules/ajv",
"//:node_modules/ansi-colors",
"//:node_modules/browser-sync",
"//:node_modules/browserslist",
Expand All @@ -192,7 +191,6 @@ ts_project(
"//:node_modules/fast-glob",
"//:node_modules/http-proxy-middleware",
"//:node_modules/istanbul-lib-instrument",
"//:node_modules/jsonc-parser",
"//:node_modules/karma",
"//:node_modules/karma-source-map-support",
"//:node_modules/ng-packagr",
Expand Down Expand Up @@ -365,6 +363,7 @@ LARGE_SPECS = {
"//:node_modules/@types/node",
"//:node_modules/@angular/animations",
"//:node_modules/@angular/material",
"//:node_modules/ajv",
],
},
"prerender": {},
Expand Down
19 changes: 9 additions & 10 deletions packages/angular_devkit/core/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
load("@devinfra//bazel/api-golden:index_rjs.bzl", "api_golden_test_npm_package")
load("@npm2//:defs.bzl", "npm_link_all_packages")
load("//tools:defaults2.bzl", "jasmine_test", "npm_package", "ts_project")

# Copyright Google Inc. All Rights Reserved.
Expand All @@ -9,6 +10,8 @@ package(default_visibility = ["//visibility:public"])

licenses(["notice"])

npm_link_all_packages()

RUNTIME_ASSETS = glob(
include = ["**/*.json"],
# NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
Expand All @@ -29,19 +32,15 @@ ts_project(
data = RUNTIME_ASSETS,
module_name = "@angular-devkit/core",
deps = [
":node_modules/ajv",
":node_modules/ajv-formats",
":node_modules/jsonc-parser",
":node_modules/picomatch",
":node_modules/source-map",
"//:node_modules/@types/jasmine",
"//:node_modules/@types/node",
"//:node_modules/@types/picomatch",
"//:node_modules/@types/jasmine",
"//:node_modules/ajv",
"//:node_modules/ajv-formats",
"//:node_modules/jsonc-parser",
"//:node_modules/picomatch",
"//:node_modules/rxjs",
"//:node_modules/source-map",
# @node_module: typescript:es2015.proxy
# @node_module: typescript:es2015.reflect
# @node_module: typescript:es2015.symbol.wellknown
# @typings: source_map
],
)

Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/core/node/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ ts_project(
module_name = "@angular-devkit/core/node",
deps = [
"//:node_modules/@types/node",
"//:node_modules/chokidar",
"//:node_modules/rxjs",
"//packages/angular_devkit/core",
"//packages/angular_devkit/core:node_modules/chokidar",
],
)

Expand Down
3 changes: 3 additions & 0 deletions packages/angular_devkit/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
"rxjs": "7.8.2",
"source-map": "0.7.4"
},
"devDependencies": {
"chokidar": "4.0.3"
},
"peerDependencies": {
"chokidar": "^4.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/schematics/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ ts_project(
module_name = "@angular-devkit/schematics",
deps = [
":node_modules/@angular-devkit/core",
":node_modules/jsonc-parser",
"//:node_modules/@types/node",
"//:node_modules/jsonc-parser",
"//:node_modules/magic-string",
"//:node_modules/rxjs",
],
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/schematics/tools/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ ts_project(
module_name = "@angular-devkit/schematics/tools",
deps = [
"//:node_modules/@types/node",
"//:node_modules/jsonc-parser",
"//:node_modules/rxjs",
"//packages/angular_devkit/schematics",
"//packages/angular_devkit/schematics:node_modules/@angular-devkit/core",
"//packages/angular_devkit/schematics:node_modules/jsonc-parser",
"//packages/angular_devkit/schematics/tasks",
"//packages/angular_devkit/schematics/tasks/node",
],
Expand Down
4 changes: 2 additions & 2 deletions packages/schematics/angular/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ ts_project(
deps = [
":node_modules/@angular-devkit/core",
":node_modules/@angular-devkit/schematics",
":node_modules/jsonc-parser",
"//:node_modules/@types/node",
"//:node_modules/browserslist",
"//:node_modules/jsonc-parser",
"//packages/schematics/angular/third_party/github.com/Microsoft/TypeScript",
],
)
Expand Down Expand Up @@ -123,9 +123,9 @@ ts_project(
":angular",
":node_modules/@angular-devkit/core",
":node_modules/@angular-devkit/schematics",
":node_modules/jsonc-parser",
"//:node_modules/@types/jasmine",
"//:node_modules/@types/node",
"//:node_modules/jsonc-parser",
"//packages/schematics/angular/third_party/github.com/Microsoft/TypeScript",
],
)
Expand Down
23 changes: 7 additions & 16 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.