Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,7 @@ function* visit(directory: DirEntry): IterableIterator<[fileName: string, conten

export default function (): Rule {
return async (tree) => {
addPackageJsonDependency(tree, {
name: '@angular/ssr',
version: latestVersions.AngularSSR,
type: NodeDependencyType.Default,
overwrite: false,
});
let angularSSRAdded = false;

for (const [filePath, content] of visit(tree.root)) {
let updatedContent = content;
Expand Down Expand Up @@ -104,6 +99,17 @@ export default function (): Rule {

if (content !== updatedContent) {
tree.overwrite(filePath, updatedContent);

if (!angularSSRAdded) {
addPackageJsonDependency(tree, {
name: '@angular/ssr',
version: latestVersions.AngularSSR,
type: NodeDependencyType.Default,
overwrite: false,
});

angularSSRAdded = true;
}
}
}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ describe(`Migration to use the 'provideServerRendering' from '@angular/ssr'`, ()
tree.create(
'/package.json',
JSON.stringify({
dependencies: {
'@angular/ssr': '0.0.0',
},
dependencies: {},
}),
);
});
Expand Down Expand Up @@ -72,4 +70,22 @@ describe(`Migration to use the 'provideServerRendering' from '@angular/ssr'`, ()
);
expect(content.match(/@angular\/ssr/g) || []).toHaveSize(1);
});

it(`should add '@angular/ssr' when import has been changed`, async () => {
tree.create('test.ts', `import { provideServerRendering } from '@angular/platform-server';`);
const newTree = await schematicRunner.runSchematic(schematicName, {}, tree);
const { dependencies } = newTree.readJson('package.json') as {
dependencies: Record<string, string>;
};
expect(dependencies['@angular/ssr']).toBeDefined();
});

it(`should not add '@angular/ssr' dependency if no imports have been updated`, async () => {
tree.create('test.ts', `import { provideClientHydration } from '@angular/platform-browser';`);
const newTree = await schematicRunner.runSchematic(schematicName, {}, tree);
const { dependencies } = newTree.readJson('package.json') as {
dependencies: Record<string, string>;
};
expect(dependencies['@angular/ssr']).toBeUndefined();
});
});