fix(@schematics/angular): replace @angular/platform-browser-dynamic with @angular/platform-browser
#29882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with `@angular/platform-browser` The Angular CLI expliclty adds `@angular/compiler` as a polyfill when JIT mode is enabled which makes using `@angular/platform-browser-dynamic` redundant and causes the compiler to be imported twice.
alan-agius4
added
action: review
devversion
approved these changes
Mar 19, 2025
alan-agius4
added
action: merge
|
Should the dependency be removed from the package.json as well? |
|
We are still using it for testing, can be removed once angular/angular#60453 is landed. |
|
The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Angular CLI explicitly adds
@angular/compileras a polyfill when JIT mode is enabled which makes using@angular/platform-browser-dynamicredundant and causes the compiler to be imported twice.